Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix width mismatch assignment issue #191 #192

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Fix width mismatch assignment issue #191 #192

merged 2 commits into from
Dec 13, 2023

Conversation

rsharanesh
Copy link
Contributor

As mentioned in the issue, this would make the assignment more generic and compile clean with strict compile in few simulators.

@niwis niwis linked an issue Jul 31, 2023 that may be closed by this pull request
Width mismatch error in assign statement with VCS strict compile #191
Closed
niwis
niwis requested changes Jul 31, 2023
View reviewed changes
Copy link
Collaborator

@niwis niwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for spotting this. I have one suggestion regarding the solution.

src/onehot_to_bin.sv Outdated Show resolved Hide resolved
@rsharanesh @niwis
Update src/onehot_to_bin.sv
f3337e1 
Co-authored-by: Nils Wistoff <nwistoff@iis.ee.ethz.ch>
@niwis niwis merged commit 6ff3a09 into pulp-platform:master Dec 13, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niwis niwis niwis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Width mismatch error in assign statement with VCS strict compile
2 participants
@rsharanesh @niwis