Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

path: Skip checkout if possible #135

Merged
merged 6 commits into from
Sep 12, 2023
Merged

path: Skip checkout if possible #135

merged 6 commits into from
Sep 12, 2023

Conversation

niwis
Copy link
Contributor

@niwis niwis commented Sep 7, 2023

Reduce bender's footprint by skipping checkout of a package if the package path already exists and

  • path is executed (can be overruled by new --checkout flag), or
  • for locally linked packages if any command except for update is executed.

To prevent bender path from returning stale paths, a checkout is now performed automatically after executing update. This can be prevented by passing the new --no-checkout flag to update.

@niwis niwis requested a review from micprog September 7, 2023 14:15
micprog and others added 6 commits September 7, 2023 16:16
…eeded.

Signed-off-by: Nils Wistoff <nwistoff@iis.ee.ethz.ch>
Signed-off-by: Nils Wistoff <nwistoff@iis.ee.ethz.ch>
Signed-off-by: Nils Wistoff <nwistoff@iis.ee.ethz.ch>
... or on `bender update`

Signed-off-by: Nils Wistoff <nwistoff@iis.ee.ethz.ch>
Signed-off-by: Nils Wistoff <nwistoff@iis.ee.ethz.ch>
Signed-off-by: Nils Wistoff <nwistoff@iis.ee.ethz.ch>
Copy link
Member

@micprog micprog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@micprog micprog merged commit 4447df3 into master Sep 12, 2023
5 checks passed
@micprog micprog deleted the path/no-checkout branch September 12, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants