Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase softmax epsilon #11

Merged
merged 4 commits into from
Nov 29, 2024
Merged

Conversation

gamzeisl
Copy link
Collaborator

This PR increases the eps_max of softmax by 32x to allow a broader range of inputs. Additionally, the number of dividers and fifo depth are increased to maximize utilization.

@gamzeisl gamzeisl requested a review from Xeratec November 29, 2024 14:34
Copy link
Member

@Xeratec Xeratec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xeratec Xeratec merged commit 39236c9 into pulp-platform:main Nov 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants