start readable stream in paused mode #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The [node docs say](https://nodejs.org/api/stream.html#stream_two_reading_modes): > All Readable streams begin in paused mode but can be switched to flowing mode in one of the following ways: > > * Adding a 'data' event handler. > * Calling the stream.resume() method. > * Calling the stream.pipe() method to send the data to a Writable. This module seems to return a stream that starts emitting data on the next tick and doesn't wait for the 'data' event handler to be added. This PR: 1. Starts the stream in `paused` mode 2. Overrides the `.on` method on the stream to start data flowing when a `data` event is added in the same way that `.pipe` is overridden 3. Adds a test for the above
Member
|
thanks, I'm gonna merge this as a breaking change, I think it probably won't break anything, but this has been out a long time and no one complained. This way, old code will still use the old version of this module, but new users will get the new code. your test fails by the way |
Member
|
... this was written using an old version of tape that didn't output anything in that error case. updating gives and error, clearing the timeout of the second timeout fixes it. |
Member
|
merged into 2.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The node docs say:
This module seems to return a stream that starts emitting data on the next tick and doesn't wait for the 'data' event handler to be added.
This PR:
pausedmode.onmethod on the stream to start data flowing when adataevent is added in the same way that.pipeis overridden