Propagate async errors to webpack #78
Merged
+44
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Looks like the Travis errors are because there is no |
TimothyGu
approved these changes
Feb 12, 2017
Member
TimothyGu
left a comment
TimothyGu
left a comment
There was a problem hiding this comment.
Looks good to me, other than a nit.
test/fakeModuleSystem.js
Outdated
| if(request[0] && /stringify/.test(request[0])) | ||
| content = JSON.stringify(content); | ||
| return callback(null, content); | ||
| process.nextTick(() => loadCallback(null, content)); |
Member
There was a problem hiding this comment.
While at it, you can use fs.readFile() instead of fs.readFileSync() too.
Member
|
Yeah, don't worry about Travis for now. I'll fix it when I find the time too. Thanks a lot! |
Pinpickle
force-pushed
the
propagate-async-error
branch
from
1834f3d to
bf005ca
Compare
Contributor
Author
|
@TimothyGu I've made the file reading async now, as well as making |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling a module that has asynchronous errors (e.g. when an error results from using
extendorinclude), the error will not go through Webpack, but will be thrown in some async handler somewhere.This has two pretty big drawbacks:
I've fixed this by making all thrown errors in the
runfunction go through the Webpack callback. I've added tests to check that this behaviour works, and I have verified that it fixed the problem in a project I am usingpug-loaderin.I had to modify the mock Webpack loader system to actually be asynchronous, all tests should still be passing.
Edit: Turns out this fixes #77 as well