Skip to content

node_module: implement data file copy #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pcj merged 1 commit into from
Apr 22, 2019
Merged

node_module: implement data file copy #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions node/internal/node_module.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,13 @@ def _node_module_impl(ctx):
dst = ctx.new_file("%s/%s" % (name, _get_path_for_module_file(ctx, root_file, src, sourcemap)))
outputs.append(_copy_file(ctx, src, dst))

for src in ctx.files.data:
filename = src.short_path
dst = ctx.actions.declare_file(filename, sibling = root_file)
outputs.append(_copy_file(ctx, src, dst))

return struct(
files = depset(outputs),
files = depset(outputs + ctx.files.data),
node_module = struct(
identifier = name.replace(ctx.attr.separator, '_'),
name = name,
Expand Down Expand Up @@ -230,10 +235,9 @@ node_module = rule(
single_file = True,
),

# Additional data files to be included in the module, but
# excluded from the package.json 'files' attribute.
"data": attr.label_list(
allow_files = True,
doc = "Additional data files to be included in the module, but excluded from the package.json 'files' attribute",
),

# Module dependencies.
Expand Down