Add fetch messages and custom message type support #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `custom_message_type` support for publish / signal and subscribe endpoints.
parfeon
added
status: done
Add fetch messages (batch history) endpoint support to fetch history for multiple channels. feat(history): add fetch messages with message reactions Add fetch messages with reactions support. feat(custom-message-type): add support for fetch messages Add `include_custom_message_type` support for fetch messages endpoint.
parfeon
changed the title
seba-aln
approved these changes
Jan 3, 2025
| begin | ||
| @app.record_telemetry(@telemetry_name, telemetry_time_start, ::Time.now.to_f) | ||
| rescue StandardError => error | ||
| Pubnub.logger.warn('Pubnub::Event') { "Couldn't record telemetry because of #{error}\n#{error.backtrace.join("\n")}" } |
There was a problem hiding this comment.
I assume the rename was to fit in line length limit. error name was better, but I understand ;)
| end | ||
| end | ||
|
|
||
| it "__channel__demo3___max__5__start__nil___end__nil___include_uuid__false___include_meta__false___include_message_actions__false___include_message_type__false___include_custom_message_type__false__http_sync__true___callback__nil___encrypted__true___random_iv__true_" do |
| random_iv = options.key?(:random_iv) ? options[:random_iv] : true | ||
| options[:crypto_module] = Crypto::CryptoModule.new_legacy(options[:cipher_key], random_iv) if options[:cipher_key] | ||
|
|
||
| super |
|
@pubnub-release-bot release |
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(history): add batch history support
Add fetch messages (batch history) endpoint support to fetch history for multiple channels.
feat(history): add fetch messages with message reactions
Add fetch messages with reactions support.
feat(custom-message-type): add support for fetch messages
Add
include_custom_message_typesupport for fetch messages endpoint.feat(custom-message-type): add support for publish and subscribe
Add
custom_message_typesupport forpublish/signalandsubscribeendpoints.