- 
                Notifications
    You must be signed in to change notification settings 
- Fork 114
Add support for switching cipher methods #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e873982    to
    aa0369c      
    Compare
  
    5802f8a    to
    c541138      
    Compare
  
    c541138    to
    7c6e789      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| This is potentially a breaking changeIf you use multiple clients, enabling AES.GCM will break other clients that have not enabled this because they will not be able to decipher the messages. If the python SDK is the only one in use, there should not be any problems since history messages can be deciphered by a fallback algorithm. ConfigurationNothing has to be changed for this to work with other SDKs without breaking compatibility. If, however, you wish to enable GCM ciphering, use the example below:  | 
| @pubnub-release-bot release | 
| 🚀 Release successfully completed 🚀 | 
feat: Option to change the ciphering method
Introduced option to select ciphering method for encoding messages and files. The default behavior is unchanged. More can be read in this comment