Fix subscription reference timetoken #464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix incorrect subscription reference timetoken (used by listeners to filter old messages) caused by the server returning timetoken older than previous one because of MX. fix(subscription-set): fix event handling by subscription Fix the issue because of which all subscriptions of the subscription set have been requested to handle the received event.
parfeon
added
status: done
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
mohitpubnub
approved these changes
Jul 15, 2025
parfeon
changed the title
Replace the `onpagehide` listener assignment with `addEventListener` to ensure that the listener won't be replaced.
mohitpubnub
approved these changes
Jul 15, 2025
| transport = middleware; | ||
| if (configurationCopy.subscriptionWorkerUnsubscribeOfflineClients) { | ||
| window.onpagehide = (event) => { | ||
| window.addEventListener('pagehide', (event) => { |
Contributor
There was a problem hiding this comment.
okay so this will not overwrite others
and event.persisted will be false for both - soft and hard refresh 👍🏻
Contributor
Author
|
@pubnub-release-bot release |
pubnub-release-bot
requested review from
kazydek and
techwritermat
as code owners
Contributor
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(subscription): fix subscription reference timetoken
Fix incorrect subscription reference timetoken (used by listeners to filter old messages) caused by the server returning timetoken older than the previous one because of MX.
fix(subscription-set): fix event handling by subscription
Fix the issue because of which all subscriptions of the subscription set have been requested to handle the received event.