Fix/unsubscribe with subscription set #462
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
…equest is partially removing channel entity. Not entirly remove map of active subscription entity list
mohitpubnub
commented
Jul 7, 2025
| @@ -1511,12 +1511,16 @@ export class PubNubCore< | |||
| details: `Unregister event handle capable:`, | |||
| })); | |||
|
|
|||
| if ( | |||
There was a problem hiding this comment.
@parfeon this condition was always clearing the reference map on first unsubscribe() call
|
merged changes with commit 1d90f4e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: update condition which removes reference tracking map of active subscription.
Fixes issue of subsequent unsubscribe() failure due to reference map deletion on first unsubscribe call.