Skip to content

Remove 'contact support' in case of network error. #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 23, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions .pubnub.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
name: java
version: 6.4.1
version: 6.4.2
schema: 1
scm: github.com/pubnub/java
files:
- build/libs/pubnub-gson-6.4.1-all.jar
- build/libs/pubnub-gson-6.4.2-all.jar
sdks:
-
type: library
Expand All @@ -23,8 +23,8 @@ sdks:
-
distribution-type: library
distribution-repository: maven
package-name: pubnub-gson-6.4.1
location: https://repo.maven.apache.org/maven2/com/pubnub/pubnub-gson/6.4.1/pubnub-gson-6.4.1.jar
package-name: pubnub-gson-6.4.2
location: https://repo.maven.apache.org/maven2/com/pubnub/pubnub-gson/6.4.2/pubnub-gson-6.4.2.jar
supported-platforms:
supported-operating-systems:
Android:
Expand Down Expand Up @@ -115,6 +115,11 @@ sdks:
is-required: Required

changelog:
- date: 2023-11-23
version: v6.4.2
changes:
- type: bug
text: "Handle unencrypted message in subscribe and history when crypto configured (error flag is set on message result)."
- date: 2023-10-30
version: v6.4.1
changes:
Expand Down
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
## v6.4.2
November 23 2023

#### Fixed
- Handle unencrypted message in subscribe and history when crypto configured (error flag is set on message result).

## v6.4.1
October 30 2023

Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,13 @@ You will need the publish and subscribe keys to authenticate your app. Get your
<dependency>
<groupId>com.pubnub</groupId>
<artifactId>pubnub-gson</artifactId>
<version>6.4.1</version>
<version>6.4.2</version>
</dependency>
```

* for Gradle, add the following dependency in your `gradle.build`:
```groovy
implementation 'com.pubnub:pubnub-gson:6.4.1'
implementation 'com.pubnub:pubnub-gson:6.4.2'
```

2. Configure your keys:
Expand Down
2 changes: 1 addition & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ plugins {
}
group = 'com.pubnub'

version = '6.4.1'
version = '6.4.2'

description = """"""

Expand Down
2 changes: 1 addition & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ SONATYPE_HOST=DEFAULT
SONATYPE_AUTOMATIC_RELEASE=true
GROUP=com.pubnub
POM_ARTIFACT_ID=pubnub-gson
VERSION_NAME=6.4.1
VERSION_NAME=6.4.2
POM_PACKAGING=jar

POM_NAME=PubNub Java SDK
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/pubnub/api/PubNub.java
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ public class PubNub {
private static final int TIMESTAMP_DIVIDER = 1000;
private static final int MAX_SEQUENCE = 65535;

private static final String SDK_VERSION = "6.4.1";
private static final String SDK_VERSION = "6.4.2";
private final ListenerManager listenerManager;
private final StateManager stateManager;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@ public final class PubNubErrorBuilder {
public static final int PNERR_CONNECT_EXCEPTION = 102;

/**
* Please check network connectivity. Please contact support with error
* details if issue persists.
* Please check network connectivity.
*/
public static final int PNERR_HTTP_ERROR = 103;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ enum class PubNubError(private val code: Int, val message: String) {

HTTP_ERROR(
103,
"HTTP Error. Please check network connectivity. Please contact support with error details if the issue persists."
"HTTP Error. Please check network connectivity."
),

MESSAGE_MISSING(
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/com/pubnub/api/PubNubTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ public void getVersionAndTimeStamp() {
pubnub = new PubNub(pnConfiguration);
String version = pubnub.getVersion();
int timeStamp = pubnub.getTimestamp();
Assert.assertEquals("6.4.1", version);
Assert.assertEquals("6.4.2", version);
Assert.assertTrue(timeStamp > 0);
}

Expand Down