Getting started crash fix #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CraigLn
approved these changes
Nov 2, 2022
|
|
||
| } | ||
|
|
||
| func didPreloadData(windowScene: UIWindowScene) { |
There was a problem hiding this comment.
Smallest of requests, but can this method be renamed to better specify its purpose in displaying/building the UI?
There was a problem hiding this comment.
sure thing, is setupView(with windowScene: UIWindowScene) ok for you?
|
Also make sure to coordinate with @kazydek to have the Getting Started code samples updated to reflect these changes. |
jguz-pubnub
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In code race condition appears and is affecting loading data on fresh application and causing crash. To fix it the implementation is prepared, it delays data fetch until the data is loaded properly.