Add functions to opt-out "smart heartbeat" #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add functions which allow to enable and disable "smart heartbeat" behavior for automatic heartbeat: `pubnub_enable_smart_heartbeat` and `pubnub_disable_smart_heartbeat`. fix(auto-heartbeat): fix dead lock on secondary thread Fix issue which caused deadlock on secondary thread and as result heartbeat stop. fix(windows): fix function signature and call Fix signature of `pbntf_init_callback` and its usage in Windows dedicated code.
parfeon
requested review from
Xavrax,
seba-aln and
KGronek-Pubnub
as code owners
parfeon
added
status: done
KGronek-Pubnub
approved these changes
Jun 13, 2025
|
@parfeon before merging please check changes in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(auto-heartbeat): add functions to opt-out "smart heartbeat"
Add functions which allow to enable and disable "smart heartbeat" behavior for automatic heartbeat:
pubnub_enable_smart_heartbeatandpubnub_disable_smart_heartbeat.fix(auto-heartbeat): fix dead lock on secondary thread
Fix issue which caused deadlock on secondary thread and as result heartbeat stop.
fix(windows): fix function signature and call
Fix signature of
pbntf_init_callbackand its usage in Windows dedicated code.