Fixes #10677: Fixed profile picture on profile page

[KarishmaVanwari]

Fixes #10677

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• PR is descriptively titled 📑 and links the original issue above 🔗
• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts 📁
• screenshots/GIFs are attached 📎 in case of UI updation
• ask @publiclab/reviewers for help, in a comment below

[gitpod-io]

[govindgoel]

@KarishmaVanwari can you share a screenshot as well if it is working fine

[KarishmaVanwari]

@govindgoel This is what I can see locally:

I tried to edit the profile picture, but I am unable to do so, this is what I see :

As per your comment here, does it mean that the changes will reflect only when in production (since I am unable to check it locally)? Do correct me if I'm wrong. Thanks!

[TildaDares]

Hi @KarishmaVanwari, to upload a picture you would have to install ImageMagick. https://github.com/publiclab/plots2/blob/6be83ac1945a4e1ba5b6f8e3093d11168765f432/doc/PREREQUISITES.md#image-libraries-optional

[KarishmaVanwari]

Hi @KarishmaVanwari, to upload a picture you would have to install ImageMagick. https://github.com/publiclab/plots2/blob/6be83ac1945a4e1ba5b6f8e3093d11168765f432/doc/PREREQUISITES.md#image-libraries-optional

Thank you so much @TildaDares! I was successfully able to upload the image. The profile picture is visible now on the profile page, as you can see :

@govindgoel @TildaDares I hope this works. Apologies for delay since I had been a little busy with my university exams. Thanks!

[codecov]

Codecov Report

Merging #10802 (4c35616) into main (ed86e58) will increase coverage by 56.46%.
The diff coverage is n/a.

❗ Current head 4c35616 differs from pull request most recent head 369019d. Consider uploading reports for the commit 369019d to get more accurate results

@@             Coverage Diff             @@
##             main   #10802       +/-   ##
===========================================
+ Coverage   25.87%   82.34%   +56.46%     
===========================================
  Files          98       98               
  Lines        7688     5991     -1697     
===========================================
+ Hits         1989     4933     +2944     
+ Misses       5699     1058     -4641     

Impacted Files	Coverage Δ
app/models/revision.rb	88.29% <0.00%> (+3.19%)	⬆️
app/models/node_tag.rb	100.00% <0.00%> (+3.70%)	⬆️
app/models/image.rb	82.05% <0.00%> (+5.12%)	⬆️
app/models/tag.rb	93.23% <0.00%> (+5.79%)	⬆️
app/models/concerns/node_shared.rb	90.29% <0.00%> (+6.31%)	⬆️
app/models/concerns/statistics.rb	100.00% <0.00%> (+6.55%)	⬆️
app/models/tag_selection.rb	96.00% <0.00%> (+8.00%)	⬆️
app/models/user.rb	86.64% <0.00%> (+9.38%)	⬆️
app/models/doc_list.rb	65.00% <0.00%> (+10.00%)	⬆️
app/models/node.rb	91.27% <0.00%> (+14.42%)	⬆️
... and 52 more

[github-actions]

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/5952246424/artifacts/204236795

[TildaDares]

Tested on my local env. It works!!

Thanks @KarishmaVanwari. Great work!

[KarishmaVanwari]

Thank you @TildaDares!!!

[jywarren]

My apologies, i tried resolving the merge conflicts and made a mistake, but I fixed it. Once these tests pass we are good to merge! Thanks!!!

[codeclimate]

Code Climate has analyzed commit 369019d and detected 0 issues on this pull request.

View more on Code Climate.

[github-actions]

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/6098726996/artifacts/211569067

[jywarren]

OK, excellent! Thank you!!!