-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document SpreadsheetLayers and spin out Leaflet.SpreadsheetLayer as a stand-alone Leaflet library #121
Labels
Comments
Note that I'm having trouble instantiating a new layer... not sure why it's not working. @kevinzluo why does this have to be a LayerGroup? |
Hello,
I'm so sorry, but I really haven't been active in the community lately. I'm
caught up in school and really can't take a look right now, but I will as
soon as a have the chance. There is a break coming up in mid March so I
could try then? I remember when I was creating the layer I had some issues
as well, but there was some way to do it.
My apologies!
… |
No issue @kevinzluo, we understand your situation and you are most welcome to contribute anytime, as per your convenience. Thanks! |
yes, sorry @kevinzluo i didn't mean to imply you needed to do this either!
I was just looking at projects people might be able to do to generally
improve the codebase and wanted to keep you in the loop! Good luck with
school and thanks for all your help!
…On Tue, Feb 19, 2019 at 10:50 PM Gaurav Sachdeva ***@***.***> wrote:
No issue @kevinzluo <https://github.com/kevinzluo>, we understand your
situation and you are most welcome to contribute anytime, as per your
convenience. Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#121 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJy6mFY7Z3V5Zrt0QL_Hme_Jrzciyks5vPO__gaJpZM4bELLt>
.
|
jywarren
changed the title
Spin out Leaflet.SpreadsheetLayer as a stand-alone Leaflet library
Document SpreadsheetLayers and spin out Leaflet.SpreadsheetLayer as a stand-alone Leaflet library
Jan 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@kevinzluo made a fantastic component for this library which really deserves to be its own Leaflet Plugin. Let's do it!
See a recent minimal Leaflet plugin I created here for reference: https://github.com/publiclab/leaflet-multispectral
Read more here: https://github.com/publiclab/leaflet-environmental-layers/blob/master/src/util/googleSpreadsheetLayer.js
We could make it in this repository: https://github.com/publiclab/leaflet-spreadsheet
I made a test spreadsheet here: https://docs.google.com/spreadsheets/d/14BvU3mEqvI8moLp0vANc7jeEvb0mnmYvH4I0GkwVsiU/edit#gid=0
Docs could be as follows, roughly:
There are other libraries that do parts of this, but I still think this is an elegant and flexible implementation that's worth spinning out:
The text was updated successfully, but these errors were encountered: