Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gets all of the Publiclab's repos from Github API #65

Merged
merged 1 commit into from
Oct 13, 2018

Conversation

Rishabh570
Copy link
Collaborator

Fixes #64
Now we get all of the repos (48) instead of 30 by hitting the Github API...
I'll be posting a GIF soon...

@Rishabh570
Copy link
Collaborator Author

@jywarren @gauravano It turns out that fetching the contributors of all 48 repositories is not possible because we hit API limit (60 per hour) while doing so...

I think we can handle this in one of these ways,

  • Fetch first 30 repositories in most recently pushed manner (this will leave those repos which are not in active development. At max, we will miss 10 contributors if we take this route)
  • Hardcode the repository names which have maximum unique contributors (I mean handpick the repos so that we can make sure we include unique contributors from each repo).

I think 1st option is a way to go...

@jywarren
Copy link
Member

Thanks for thinking through this! How many requests are required per repository?

I think for now we could go for the ones with recent activity -- there are plenty of PL repos that are essentially "archived" and have no activity, and 30 is plenty for now. So +1 for #1!

@Rishabh570
Copy link
Collaborator Author

Rishabh570 commented Oct 12, 2018

Looking at the network tab, it is 2 per repo...1 for fetching repos(30), one should be for getting plots2 contributors...need to fit all these under 60, time to do some maths 😄

@Rishabh570
Copy link
Collaborator Author

@jywarren Okay, so what I've done is, I've fetched all the 48 repos according to recent pushes/recent activity and spliced that array to get first 30 of them, I think there is some improvement because total contributors number has increased, here is the GIF...

ezgif com-optimize 2

What do you think?

@jywarren
Copy link
Member

jywarren commented Oct 12, 2018 via email

@Rishabh570
Copy link
Collaborator Author

Okay, great. I've pushed these changes so if it's fine...you can merge this :)

@Rishabh570
Copy link
Collaborator Author

Hi @jywarren , is something missing in this? Do I need to update something here?

@jywarren
Copy link
Member

Sorry, been very occupied at a public lab event in China! Looks great and will publish in a few days!!! Thanks!!

@jywarren jywarren merged commit bc630b0 into publiclab:main Oct 13, 2018
@ghost ghost removed the in progress label Oct 13, 2018
TildaDares pushed a commit to TildaDares/community-toolbox that referenced this pull request Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants