-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gets all of the Publiclab's repos from Github API #65
Conversation
@jywarren @gauravano It turns out that fetching the contributors of all 48 repositories is not possible because we hit API limit (60 per hour) while doing so... I think we can handle this in one of these ways,
I think 1st option is a way to go... |
Thanks for thinking through this! How many requests are required per repository? I think for now we could go for the ones with recent activity -- there are plenty of PL repos that are essentially "archived" and have no activity, and 30 is plenty for now. So +1 for |
Looking at the network tab, it is 2 per repo...1 for fetching repos(30), one should be for getting plots2 contributors...need to fit all these under 60, time to do some maths 😄 |
@jywarren Okay, so what I've done is, I've fetched all the 48 repos according to recent pushes/recent activity and spliced that array to get first 30 of them, I think there is some improvement because total contributors number has increased, here is the GIF... What do you think? |
Yay!! This is perfect. Let's do it!
…On Fri, Oct 12, 2018, 3:57 PM Rishabh Rawat ***@***.***> wrote:
@jywarren <https://github.com/jywarren> Okay, so what I've done is, I've
fetched all the 48 repos according to recent pushes/recent activity and
spliced that array to get first 30 of them, I think there is some
improvement because total contributors number has increased, here is the
GIF...
[image: ezgif com-optimize 2]
<https://user-images.githubusercontent.com/25483260/46855825-6ac05680-ce22-11e8-8b0b-ff995bef8df2.gif>
What do you think?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#65 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ2zpegm2_oOYQ47egXJAuwD15o18ks5ukEtPgaJpZM4XXe75>
.
|
Okay, great. I've pushed these changes so if it's fine...you can merge this :) |
Hi @jywarren , is something missing in this? Do I need to update something here? |
Sorry, been very occupied at a public lab event in China! Looks great and will publish in a few days!!! Thanks!! |
Fixes #64
Now we get all of the repos (48) instead of 30 by hitting the Github API...
I'll be posting a GIF soon...