Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notifications for user acknowledgement #236

Merged
merged 1 commit into from
Jul 25, 2019

Conversation

Rishabh570
Copy link
Collaborator

Fixes #206
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

@Rishabh570 Rishabh570 changed the title [ WIP ] Add notifications for user acknowledge [ WIP ] Add notifications for user acknowledgement Jul 19, 2019
@Rishabh570
Copy link
Collaborator Author

@jywarren Please take a look here...almost done, just some little changes are remaining. These notifications will tell the user if anything unexpected happens due to network/API reasons.

not gif 2

@jywarren
Copy link
Member

jywarren commented Jul 19, 2019 via email

@Rishabh570
Copy link
Collaborator Author

It'll be ready by tomorrow, I'll also tag reviewers here once it is ready. 👍

@Rishabh570 Rishabh570 changed the title [ WIP ] Add notifications for user acknowledgement Add notifications for user acknowledgement Jul 24, 2019
@Rishabh570
Copy link
Collaborator Author

@publiclab/reviewers This is ready for review. Please take a look.

@jywarren
Copy link
Member

:-) looks great! Go ahead and merge!

@Rishabh570
Copy link
Collaborator Author

Thanks! 🎉

@Rishabh570 Rishabh570 merged commit 558b637 into publiclab:main Jul 25, 2019
TildaDares pushed a commit to TildaDares/community-toolbox that referenced this pull request Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add user notifications
2 participants