Recent Contributors section - refactor followup #231
Conversation
|
@jywarren A step towards our flexible queryTime in recent contribs logic, making the section of the code flexible and segregated so that future improvements can be (more) easily installable and maintainable. Please take a look :) |
Rishabh570
changed the title
| if(!contributorSet.has(contributor.login)) { | ||
| contributorSet.add(contributor.login); | ||
| AllContributors.push(contributor); | ||
| } |
There was a problem hiding this comment.
Looks super nice! Some extreme indentation here, though, did you want to adjust that? Thanks!
|
This looks really nice. Do you think it starts to need more documentation in the README about code structure yet, or not quite yet? Like in this README: https://github.com/publiclab/PublicLab.Editor/ This can be merged either way! Thanks!!! |
|
Yes, a more descriptive readme would surely help everyone who's trying to involve in the project...I have that as a to-do in the project. I am thinking of something like showing the flowchart for general control flow and then explaining what every part of the code does. |
Rishabh570
force-pushed
the
refactor-followup
branch
from
36a500f to
372e280
Compare
Rishabh570
changed the title
|
@jywarren This is ready to merge I think, please take a look :) |
|
Awesome!!!! |
* followup refactor of utils. * fix indentation
No issue opened for this. It is a step towards making the codebase more flexible and maintainable.
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake testfixes #0000-style reference to original issue #@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.
Thanks!