Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve dropdown logic and change urlHash source. #229

Merged
merged 1 commit into from
Jul 2, 2019

Conversation

Rishabh570
Copy link
Collaborator

Fixes #228
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

@Rishabh570
Copy link
Collaborator Author

@jywarren Please take a look here...

@jywarren
Copy link
Member

jywarren commented Jun 29, 2019 via email

@Rishabh570
Copy link
Collaborator Author

Yeah, this won't affect anything related to the links, the repository name will still be there in the URL as the hash...just the source of the file will be changed from node_modules/ to examples/.

@Rishabh570
Copy link
Collaborator Author

Hi @jywarren, please take a look here...once this gets merged I can update my stale issues list PR and FTO issue authors list PR and they'll be ready for review also :)

@Rishabh570
Copy link
Collaborator Author

@jywarren Should I go ahead with this one?

@jywarren
Copy link
Member

jywarren commented Jul 2, 2019

Hi, Rishabh! So sorry... looking now.

@jywarren
Copy link
Member

jywarren commented Jul 2, 2019

Sounds great. Let's do it. Thanks for your patience!

@Rishabh570 Rishabh570 merged commit 15b983d into publiclab:main Jul 2, 2019
TildaDares pushed a commit to TildaDares/community-toolbox that referenced this pull request Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue in dropdown logic
2 participants