-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add list of FTO issue authors. #225
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exciting!!! You should mention this in this week's check-in, folks will be
very happy! Ping me when you'd like a review? Thanks a ton!!!
…On Mon, Jun 24, 2019 at 12:34 AM Rishabh Rawat ***@***.***> wrote:
FIxes #13 <#13>
Make sure these boxes are checked before your pull request (PR) is ready
to be reviewed and merged. Thanks!
- tests pass -- look for a green checkbox ✔️ a few minutes after
opening your PR -- or run tests locally with rake test
- code is in uniquely-named feature branch and has no merge conflicts
- PR is descriptively titled
- PR body includes fixes #0000-style reference to original issue #
- ask @publiclab/reviewers for help, in a comment below
We're happy to help you get this ready -- don't be afraid to ask for help,
and *don't be discouraged* if your tests fail at first!
If tests do fail, click on the red X to learn why by reading the logs.
Please be sure you've reviewed our contribution guidelines at
https://publiclab.org/contributing-to-public-lab-software
We have a loose schedule of reviewing and pulling in changes every Tuesday
and Friday, and publishing changes on Fridays.
Thanks!
------------------------------
You can view, comment on, or merge this pull request online at:
#225
Commit Summary
- add list of fto authors.
File Changes
- *M* dist/community-toolbox.js
<https://github.com/publiclab/community-toolbox/pull/225/files#diff-0>
(77)
- *M* examples/demo.css
<https://github.com/publiclab/community-toolbox/pull/225/files#diff-1>
(10)
- *M* examples/demo.js
<https://github.com/publiclab/community-toolbox/pull/225/files#diff-2>
(34)
- *M* index.html
<https://github.com/publiclab/community-toolbox/pull/225/files#diff-3>
(6)
- *A* src/UI/ftoAuthorsUI.js
<https://github.com/publiclab/community-toolbox/pull/225/files#diff-4>
(12)
- *M* src/scripts/community-toolbox.js
<https://github.com/publiclab/community-toolbox/pull/225/files#diff-5>
(4)
Patch Links:
- https://github.com/publiclab/community-toolbox/pull/225.patch
- https://github.com/publiclab/community-toolbox/pull/225.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#225?email_source=notifications&email_token=AAAF6JYLWUK6O6TVKSW43UDP4BFB5A5CNFSM4H224FWKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G3GGPSA>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAF6J7OMCHSIK36TO6NRPLP4BFB5ANCNFSM4H224FWA>
.
|
Yeah, I've mentioned this in the check-in...I'll let you know when it's ready :) |
@jywarren It is ready now 😄. |
Hi @jywarren, here's how it looks, Is it good to go? |
Oh awesome! Yes! Thanks!!!
…On Thu, Jul 4, 2019, 11:00 AM Rishabh Rawat ***@***.***> wrote:
Hi @jywarren <https://github.com/jywarren>, here's how it looks,
[image: Screenshot from 2019-07-04 20-27-47]
<https://user-images.githubusercontent.com/25483260/60675590-5afa0e00-9e9a-11e9-9fca-68c8fd9c5fba.png>
Is it good to go?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#225?email_source=notifications&email_token=AAAF6J2MLXBEVDX4VIIGSQLP5YF77A5CNFSM4H224FWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZHUJWI#issuecomment-508511449>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAF6J26LPF63MWXPYLTYFTP5YF77ANCNFSM4H224FWA>
.
|
TildaDares
pushed a commit
to TildaDares/community-toolbox
that referenced
this pull request
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIxes #13
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
fixes #0000
-style reference to original issue #@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.
Thanks!