Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dropdown autocomplete for navigation around repositories #219

Merged
merged 2 commits into from
Jun 21, 2019

Conversation

Rishabh570
Copy link
Collaborator

Fixes #203
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

@Rishabh570
Copy link
Collaborator Author

Here's a GIF of my changes,

dropdown

@jywarren @publiclab/reviewers I've made an autocomplete dropdown for selecting repositories because a normal dropdown would be very long taking into account the number of repositories.

@Rishabh570
Copy link
Collaborator Author

@jywarren @publiclab/reviewers Please take a look here, it is ready for review...

Copy link

@sagarpreet-chadha sagarpreet-chadha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks great :)

@Rishabh570
Copy link
Collaborator Author

Thanks @sagarpreet-chadha, is it ready to merge?

@jywarren
Copy link
Member

This looks good! Perhaps though, we should put this further down, or under an expanding section that at first just shows the currently selected repo? And although it would be a lot, potentially without naming some of them, it would seem confusing to show an empty box. People might not know what the possibilities are?

What if we have something that says Showing [all repositories +] or Showing [mapknitter +] -- where [ ] is a dropdown? I like what you've done with the autocomplete! I'm just not sure because i feel like we would need to show some kind of list. Maybe the module selector in http://sequencer.publiclab.org could be an interesting example to look at?

Great work, @Rishabh570 !!!!

@Rishabh570
Copy link
Collaborator Author

@jywarren Right, the user might not be able to figure out what to type so providing a dropdown is a better option. So I've changed it, now it looks like,

dropdown_final

I think this is easier to understand than the autocomplete, what do you think?

@Rishabh570
Copy link
Collaborator Author

Hi @jywarren, please take a look here...if the changes in my latest GIF look good I can push them.
Thanks!

@jywarren
Copy link
Member

jywarren commented Jun 19, 2019 via email

@Rishabh570
Copy link
Collaborator Author

Okay, so I've pushed the latest changes, please take a look here: http://rishabh570.me/community-toolbox

@Rishabh570
Copy link
Collaborator Author

@jywarren Is it ready to merge?

@jywarren
Copy link
Member

jywarren commented Jun 21, 2019 via email

@Rishabh570
Copy link
Collaborator Author

Sure, thanks!!! 😃 🎉

@Rishabh570 Rishabh570 merged commit e13747e into publiclab:main Jun 21, 2019
TildaDares pushed a commit to TildaDares/community-toolbox that referenced this pull request Apr 28, 2021
…ab#219)

* add dropdown for navigation around repositories.

* make autocomplete a dropdown.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dropdown for navigation around different repositories
3 participants