-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dropdown autocomplete for navigation around repositories #219
Conversation
Here's a GIF of my changes, @jywarren @publiclab/reviewers I've made an autocomplete dropdown for selecting repositories because a normal dropdown would be very long taking into account the number of repositories. |
@jywarren @publiclab/reviewers Please take a look here, it is ready for review... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks great :)
Thanks @sagarpreet-chadha, is it ready to merge? |
This looks good! Perhaps though, we should put this further down, or under an expanding section that at first just shows the currently selected repo? And although it would be a lot, potentially without naming some of them, it would seem confusing to show an empty box. People might not know what the possibilities are? What if we have something that says Great work, @Rishabh570 !!!! |
@jywarren Right, the user might not be able to figure out what to type so providing a dropdown is a better option. So I've changed it, now it looks like, I think this is easier to understand than the autocomplete, what do you think? |
Hi @jywarren, please take a look here...if the changes in my latest GIF look good I can push them. |
It looks awesome. Very cool. Thanks!!!!
…On Sat, Jun 15, 2019 at 11:09 PM Rishabh Rawat ***@***.***> wrote:
Hi @jywarren <https://github.com/jywarren>, please take a look here...if
the changes in my latest GIF look good I can push them.
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#219?email_source=notifications&email_token=AAAF6J4YLZ7YYNLAAFSQK2LP2WVD7A5CNFSM4HWJQYI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXZECRQ#issuecomment-502415686>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAF6JZPIJM7CTEDZVZ5UB3P2WVD7ANCNFSM4HWJQYIQ>
.
|
Okay, so I've pushed the latest changes, please take a look here: http://rishabh570.me/community-toolbox |
@jywarren Is it ready to merge? |
Yes! Do you want to go ahead?
…On Fri, Jun 21, 2019, 1:26 AM Rishabh Rawat ***@***.***> wrote:
@jywarren <https://github.com/jywarren> Is it ready to merge?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#219?email_source=notifications&email_token=AAAF6J6TVRVTCJZU4W2FEGLP3RQ7XA5CNFSM4HWJQYI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYHOYPY#issuecomment-504294463>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAF6J7KJXF4LCMSDQM3Q3LP3RQ7XANCNFSM4HWJQYIQ>
.
|
Sure, thanks!!! 😃 🎉 |
…ab#219) * add dropdown for navigation around repositories. * make autocomplete a dropdown.
Fixes #203
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
fixes #0000
-style reference to original issue #@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.
Thanks!