Skip to content

Basic support for asyncio clients #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Feb 21, 2020
Merged

Basic support for asyncio clients #19

merged 21 commits into from
Feb 21, 2020

Conversation

public
Copy link
Owner

@public public commented Feb 17, 2020 •
edited
Loading

This adds an aiohttp based client implementation and also a lot of duplication that could benefit from some refactoring still. It's inspired by grpc/proposal#155

Solves #10

Todo:

  • Support new streaming read/write API
  • Refactor to reduce duplication.
  • Make requests in *Calls instead of *Multicallable.__call__
  • Refactor timeout handling to reduce nesting.

@public public force-pushed the asyncio-client branch 3 times, most recently from 77c7dca to 4fca491 Compare February 17, 2020 16:14
@public public changed the title WIP: Basic support for asyncio clients Basic support for asyncio clients Feb 21, 2020
@public public merged commit 4a2b2f0 into master Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@public