Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for map zooming recursion #135

Merged
merged 4 commits into from
Apr 22, 2024
Merged

Fix for map zooming recursion #135

merged 4 commits into from
Apr 22, 2024

Conversation

josephlacey
Copy link
Contributor

@josephlacey josephlacey requested a review from aepyornis April 16, 2024 18:13
@josephlacey
Copy link
Contributor Author

@aepyornis This fix seems to deal with the zooming bug. It needs review to confirm.

If it indeed does fix, this would be a good opportunity to walk through the tagging and release workflow. If it's as simple as merging develop into main and generating a new tag, awesome. Though with the missing library versions from two weeks ago, maybe deployment requires a little more massaging.

Also the Github cli tool to create PRs includes everything on the current branch from the previous merge, so your recent commits are also included. I can rewrite the history here if you don't want to include those.

@aepyornis
Copy link
Contributor

aepyornis commented Apr 18, 2024

Looks great. Ah the header! good find. I'm wondering if I had a reason for the || 0 or if that was just defensive?

We can include those commits, that's cool.

yes to update you:

  • update the version in package.json
  • merge into main
  • make a tag on the merge commit. github will automatically build the release

then in littlesis-rails

  • update littlesis.yml with the commit
  • run lscmd bundle exec rails runner lib/scripts/download_oligrapher_assets.rb v4.0.15 (or whatever the tag is) on the server and restart

open to suggestions to improve that deployment process too.

@josephlacey josephlacey merged commit 8cb80e6 into main Apr 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants