Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test case and fix for default value bug #528

Closed
wants to merge 2 commits into from
Closed

Test case and fix for default value bug #528

wants to merge 2 commits into from

Conversation

gvuyk
Copy link
Contributor

@gvuyk gvuyk commented Feb 16, 2018

This PR contains:

  • IMPROVED TESTS
  • A BUGFIX

Describe the problem you have without this PR

A default value of 0 is ignored
I'm assuming the expected behavior is for the default value to be stored regardless of its value, except when its null/undefined or limited by the "type"

@pubkey pubkey closed this in f5ec182 Feb 16, 2018
@pubkey
Copy link
Owner

pubkey commented Feb 16, 2018

Thank you @gvuyk for that great PR 👍
I added the test and a modified version of your fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants