Failing test case for importing dump with attachments #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I fixed an error which threw the exception on import. |
|
Thanks again. That's good to me. I've already implemented a basic workaround that save & restore attachments for each doc in the dump. Maybe I'll dig deeper when I'll look into sync / replication. @pubkey Is there any plan / desire to add support for attachments in dumps? |
|
I added it to the backlog. I have no plans to implement it. If you have the time, a PR would be nice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Describe the problem you have without this PR
Actually, I'm not completely sure what I'm trying to do is supposed to be supported. That's why I'm opening a PR with a test case instead of an issue, so you can judge by yourself.
My problem is that importing a dump of a DB that contains attachments fails with an error.
Furthermore, the attachment's data are not present in the json data produced by the dump.
Is dumping of attachments meant to supported by RxDB?