Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(indexedDB): Can't start a transaction on a closed database #1042

Merged
merged 7 commits into from
Sep 25, 2022

Conversation

nabigraphics
Copy link
Contributor

Hi @pubkey.

An error occurred while using indexedDB DOMException: IDBDatabase.transaction: Can't start a transaction on a closed database.

so, I added condition of channelState.closed to removeMessagesById.

demo

https://codesandbox.io/s/broadcast-channel-bug-6nwo0o?file=/src/App.tsx

  1. Click "Call BroadcastChannel" button
  2. if not called "randomInt(0,10) === 0" then click again

스크린샷 2022-09-23 오후 6 46 37

@nabigraphics
Copy link
Contributor Author

@pubkey Sorry, I missed test case. can you re run the CI?

@nabigraphics
Copy link
Contributor Author

스크린샷 2022-09-23 오후 10 05 44

hmm.... I don't know why test-node CI is failed..?
my macbook was test passed.. on node 17.3.0

@pubkey pubkey merged commit bcac393 into pubkey:master Sep 25, 2022
@nabigraphics
Copy link
Contributor Author

@pubkey can you publish library for this issue?

@pubkey
Copy link
Owner

pubkey commented Oct 6, 2022

Thanks for reminding.
I just released the new version 4.18.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants