Allow multiple self-dependencies #338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In uv, we don't use the `DependencyConstraints` map, but pass in the dependencies through an iterator. This means there can be duplicate dependencies in the input. This would previously make `merge_dependents` panic if a package dependent on itself twice with the same range: ```toml [package] name = "foo" version = "0.1.0" dependencies = ["foo", "foo"] ``` The fix is to ignore self-dependencies when merging dependents, given that they are always trivially true or trivially false.
konstin
force-pushed
the
konsti/dev/allow-multiple-self-dependencies
branch
from
22c7c0b to
7018db9
Compare
mpizenberg
approved these changes
May 10, 2025
konstin
added a commit
to astral-sh/uv
that referenced
this pull request
May 23, 2025
With pubgrub-rs/pubgrub#338 merged, we update PubGrub to 06ec5a5f59ffaeb6cf5079c6cb184467da06c9db
konstin
added a commit
to astral-sh/uv
that referenced
this pull request
May 23, 2025
With pubgrub-rs/pubgrub#338 merged, we update PubGrub to 06ec5a5f59ffaeb6cf5079c6cb184467da06c9db
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In uv, we don't use the
DependencyConstraintsmap, but pass in the dependencies through an iterator. This means there can be duplicate dependencies in the input. This would previously makemerge_dependentspanic if a package dependent on itself twice with the same range:The fix is to ignore self-dependencies when merging dependents, given that they are always trivially true or trivially false.