Add test for some of the pending comments in the proopsal PR #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adapts or removes tests that relied on creating durations that are now out of range. Adds new tests for maximum in-range and minimum out-of-range durations.
NormalizedTimeDurationToDays can no longer loop indefinitely, because at a certain point we will hit the upper bound of MAX_SAFE_INTEGER, so rename the test to reflect that it can loop an arbitrary but limited number of times. Add a test for the RangeError condition in NormalizedTimeDurationToDays when the time zone calculates a day length that is not a safe integer number of nanoseconds. While editing these tests, rename them to match the current name of the AO and make sure the step numbers are up to date. (Normally I wouldn't care so much about that, but these tests can be pretty confusing so it's good to be able to refer to the spec text.)
….hoursInDay The existing tests didn't cover some edge cases where implementations have to compute the exact result of `numerator / denominator`, where at least one of `numerator` and `denominator` can't be exactly represented by an IEEE-754 double precision floating point value. "precision-exact-mathematical-values-5.js" gets added in tc39#3961, so the new tests from this commit start at "precision-exact-mathematical-values-6.js".
ptomato
force-pushed
the
duration-normalize-part-2
branch
from
60538bc
to
04e26c6
Compare
|
Many thanks for pitching in. I incorporated these tests as an extra commit into tc39#3961, so will close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some other pending comments, but the expected behavior is not clear to me yet so I was waiting for an update to the PR.