Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native animations for DefaultTabBar #661

Merged
merged 1 commit into from
Jun 15, 2017

Conversation

janicduplessis
Copy link
Contributor

@janicduplessis janicduplessis commented Jun 10, 2017

This combines multiple animated values to have the same resulting value for scrollValue as the old code. There were two workarounds needed to make it work, both have PRs on the RN repo that would make it possible to remove them.

@skv-headless
Copy link
Collaborator

@janicduplessis thanks for explanation

@skv-headless skv-headless merged commit 1d3f424 into ptomasroos:viewpager Jun 15, 2017
anchengjian pushed a commit to anchengjian/react-native-scrollable-tab-view that referenced this pull request Sep 29, 2018
Use native animations for DefaultTabBar
caglaruba pushed a commit to caglaruba/react-native-scrollable-tab-view that referenced this pull request Aug 22, 2019
Use native animations for DefaultTabBar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants