Skip to content

Fix deprecated prop types #1185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alistairholt
Copy link
Contributor

ViewPropTyes and TextPropTypes have been removed from React Native. This migrates to deprecated-react-native-prop-types.

@luluhoc
Copy link

luluhoc commented Nov 23, 2022

@ptomasroos please merge

@alistairholt
Copy link
Contributor Author

@ptomasroos please?

@nickolasmdasilva
Copy link

Will you merge it @ptomasroos?

@ptomasroos
Copy link
Owner

View pager has been updated in this pull request

would be great if someone could test the branch before I merge

@alistairholt
Copy link
Contributor Author

@ptomasroos I've been using these fixes in production for a while now and everything has been fine. Not sure why @react-native-community/viewpager changed here… it seems that yarn.lock must have been out-of-date because package.json has had 3.3.0 specified for @react-native-community/viewpager for 3 years (see #1067)

@ptomasroos ptomasroos merged commit 74c3ce7 into ptomasroos:master Dec 6, 2022
@ptomasroos
Copy link
Owner

Thanks for the fix @alistairholt and taking the time to comment

@alistairholt
Copy link
Contributor Author

@ptomasroos thank you!

@arlovip
Copy link

arlovip commented Jan 17, 2023

Please release a new version to support the latest version like 0.70.6. Thank you.

@Drugak Drugak mentioned this pull request Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants