Skip to content

Remove deprecated ViewPager#1039

Merged
ptomasroos merged 2 commits intoptomasroos:masterfrom
diegolmello:master
Oct 10, 2019
Merged

Remove deprecated ViewPager#1039
ptomasroos merged 2 commits intoptomasroos:masterfrom
diegolmello:master

Conversation

@diegolmello
Copy link
Contributor

@diegolmello diegolmello commented Sep 25, 2019

No description provided.

@AlexK777
Copy link

AlexK777 commented Sep 27, 2019

closes #1035

I have made the same changes to my fork and this works as expected on my Pixel 3. @ptomasroos please merge and cut a new release.

@ptomasroos
Copy link
Owner

ptomasroos commented Sep 27, 2019

Thank you! If someone could help review it would be great as I’m busy for two weeks with web projects.

And again. Big thanks.

Tomas

@AlexK777
Copy link

AlexK777 commented Sep 27, 2019

I was able to implement the library with this change into my project and It works as expected on a device with React Native 0.61.1. I was about to submit a PR for the change but then saw this one was already out here. It looks good to me, but the more eyes the better.

@heyman333
Copy link

heyman333 commented Oct 1, 2019 •
edited
Loading

I GOT ERROR 😩

reuqireNativeCompoenent "RNCViewPager" was not found in the UIManager`

Please refer to #1038

@diegolmello
Copy link
Contributor Author

diegolmello commented Oct 1, 2019

@ptomasroos I think it's safe to merge and release.

eXist-FraGGer
eXist-FraGGer reviewed Oct 5, 2019
View reviewed changes
mistikk
mistikk reviewed Oct 10, 2019
View reviewed changes
@ptomasroos
Copy link
Owner

ptomasroos commented Oct 10, 2019

Waiting for these changes in order to merge.

@ptomasroos ptomasroos mentioned this pull request Oct 10, 2019
Closed
@diegolmello @mistikk
Update index.js
e0a4c8c 
Co-Authored-By: Mustafa Buyukcelebi <mustafa-buyukcelebi@hotmail.com>
@diegolmello
Copy link
Contributor Author

diegolmello commented Oct 10, 2019

@ptomasroos done!

@ptomasroos
Copy link
Owner

ptomasroos commented Oct 10, 2019

Thanks!

@ptomasroos ptomasroos merged commit b183e19 into ptomasroos:master Oct 10, 2019
@ptomasroos
Copy link
Owner

ptomasroos commented Oct 10, 2019

Thanks for the help in reviewing and the PR.

@mlazowik mlazowik mentioned this pull request Oct 10, 2019
Merged
@ChauVV
Copy link

ChauVV commented Oct 29, 2019 •
edited
Loading

hi @ptomasroos, I's still get this issue on android.

"react": "16.9.0", "react-native": "0.61.2", "react-native-scrollable-tab-view": "^1.0.0",

Screen Shot 2019-10-29 at 11 08 49 AM

@diegolmello diegolmello mentioned this pull request Oct 31, 2019
Merged
binchik pushed a commit to binchik/react-native-scrollable-tab-view that referenced this pull request Nov 11, 2019
@diegolmello @mistikk @binchik
Remove deprecated ViewPager (ptomasroos#1039)
c9d252a 
* remove deprecated ViewPager

* Update index.js

Co-Authored-By: Mustafa Buyukcelebi <mustafa-buyukcelebi@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@mistikk mistikk mistikk left review comments

@eXist-FraGGer eXist-FraGGer eXist-FraGGer left review comments

@Ugzuzg Ugzuzg Ugzuzg approved these changes

@alreadybe alreadybe alreadybe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@diegolmello @AlexK777 @ptomasroos @heyman333 @ChauVV @Ugzuzg @alreadybe @mistikk @eXist-FraGGer