Skip to content

Removed getDerivedState -> componentDidUpdate #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 20, 2020
Merged

Removed getDerivedState -> componentDidUpdate #163

merged 2 commits into from
Feb 20, 2020

Conversation

ptomasroos
Copy link
Owner

Tries to resolve the issue brought in #155

@ptomasroos
Copy link
Owner Author

@FrikkieSnyman does this resolve your use-case mentioned

@ptomasroos ptomasroos mentioned this pull request Feb 7, 2020
Merged
FrikkieSnyman
FrikkieSnyman reviewed Feb 7, 2020
View reviewed changes
Copy link
Contributor

@FrikkieSnyman FrikkieSnyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I think so, yeah. Not clear on why we are comparing the valueOne and valueTwo in state to the prevProps though

@ptomasroos
Fixed comparison
27af2ec 
Recreate in the case props has changed not the props vs the local state
@ptomasroos
Copy link
Owner Author

Can you try the branch out @FrikkieSnyman so I can move on and release the changes
Thanks !

@FrikkieSnyman
Copy link
Contributor

Sorry, busy week! Will try get to it this week!

@ptomasroos
Copy link
Owner Author

Thanks !

@FrikkieSnyman
Copy link
Contributor

Just tried it out, looks good! Thanks!

@ptomasroos ptomasroos merged commit 16f0e65 into master Feb 20, 2020
@ptomasroos
Copy link
Owner Author

Thanks for helping out! Will make a release

itenl pushed a commit to itenl/react-native-multi-slider that referenced this pull request Aug 27, 2021
@ptomasroos
Removed getDerivedState -> componentDidUpdate (ptomasroos#163)
04ce297 
* Removed getDerivedState -> componentDidUpdate

* Fixed comparison

Recreate in the case props has changed not the props vs the local state
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrikkieSnyman FrikkieSnyman FrikkieSnyman left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ptomasroos @FrikkieSnyman