Skip to content

Commit

Permalink
🎨 Rename all/no axis enums
Browse files Browse the repository at this point in the history
  • Loading branch information
thinkyhead committed May 22, 2021
1 parent 3220c49 commit cdbd438
Show file tree
Hide file tree
Showing 7 changed files with 13 additions and 13 deletions.
2 changes: 1 addition & 1 deletion Marlin/src/core/types.h
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ enum AxisEnum : uint8_t {
X_HEAD, Y_HEAD, Z_HEAD,
E0_AXIS = E_AXIS,
E1_AXIS, E2_AXIS, E3_AXIS, E4_AXIS, E5_AXIS, E6_AXIS, E7_AXIS,
ALL_AXES_MASK = 0xFE, NO_AXIS_MASK = 0xFF
ALL_AXES_ENUM = 0xFE, NO_AXIS_ENUM = 0xFF
};

//
Expand Down
2 changes: 1 addition & 1 deletion Marlin/src/gcode/calibrate/M852.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ void GcodeSuite::M852() {

// When skew is changed the current position changes
if (setval) {
set_current_from_steppers_for_axis(ALL_AXES_MASK);
set_current_from_steppers_for_axis(ALL_AXES_ENUM);
sync_plan_position();
report_current_position();
}
Expand Down
2 changes: 1 addition & 1 deletion Marlin/src/gcode/probe/G38.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ inline void G38_single_probe(const uint8_t move_value) {
planner.synchronize();
G38_move = 0;
endstops.hit_on_purpose();
set_current_from_steppers_for_axis(ALL_AXES_MASK);
set_current_from_steppers_for_axis(ALL_AXES_ENUM);
sync_plan_position();
}

Expand Down
12 changes: 6 additions & 6 deletions Marlin/src/lcd/marlinui.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -684,7 +684,7 @@ void MarlinUI::quick_feedback(const bool clear_buttons/*=true*/) {
#if ENABLED(MULTI_E_MANUAL)
int8_t ManualMove::e_index = 0;
#endif
AxisEnum ManualMove::axis = NO_AXIS_MASK;
AxisEnum ManualMove::axis = NO_AXIS_ENUM;

/**
* If a manual move has been posted and its time has arrived, and if the planner
Expand All @@ -695,7 +695,7 @@ void MarlinUI::quick_feedback(const bool clear_buttons/*=true*/) {
*
* To post a manual move:
* - Update current_position to the new place you want to go.
* - Set manual_move.axis to an axis like X_AXIS. Use ALL_AXES_MASK for diagonal moves.
* - Set manual_move.axis to an axis like X_AXIS. Use ALL_AXES_ENUM for diagonal moves.
* - Set manual_move.start_time to a point in the future (in ms) when the move should be done.
*
* For kinematic machines:
Expand All @@ -710,7 +710,7 @@ void MarlinUI::quick_feedback(const bool clear_buttons/*=true*/) {
if (processing) return; // Prevent re-entry from idle() calls

// Add a manual move to the queue?
if (axis != NO_AXIS_MASK && ELAPSED(millis(), start_time) && !planner.is_full()) {
if (axis != NO_AXIS_ENUM && ELAPSED(millis(), start_time) && !planner.is_full()) {

const feedRate_t fr_mm_s = (axis <= E_AXIS) ? manual_feedrate_mm_s[axis] : XY_PROBE_FEEDRATE_MM_S;

Expand All @@ -722,7 +722,7 @@ void MarlinUI::quick_feedback(const bool clear_buttons/*=true*/) {
#endif

// Apply a linear offset to a single axis
if (axis == ALL_AXES_MASK)
if (axis == ALL_AXES_ENUM)
destination = all_axes_destination;
else if (axis <= XYZE) {
destination = current_position;
Expand All @@ -731,7 +731,7 @@ void MarlinUI::quick_feedback(const bool clear_buttons/*=true*/) {

// Reset for the next move
offset = 0;
axis = NO_AXIS_MASK;
axis = NO_AXIS_ENUM;

// DELTA and SCARA machines use segmented moves, which could fill the planner during the call to
// move_to_destination. This will cause idle() to be called, which can then call this function while the
Expand All @@ -748,7 +748,7 @@ void MarlinUI::quick_feedback(const bool clear_buttons/*=true*/) {

//SERIAL_ECHOLNPAIR("Add planner.move with Axis ", AS_CHAR(axis_codes[axis]), " at FR ", fr_mm_s);

axis = NO_AXIS_MASK;
axis = NO_AXIS_ENUM;

#endif
}
Expand Down
2 changes: 1 addition & 1 deletion Marlin/src/lcd/menu/menu_bed_leveling.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@
#if ENABLED(MESH_EDIT_MENU)

inline void refresh_planner() {
set_current_from_steppers_for_axis(ALL_AXES_MASK);
set_current_from_steppers_for_axis(ALL_AXES_ENUM);
sync_plan_position();
}

Expand Down
2 changes: 1 addition & 1 deletion Marlin/src/lcd/menu/menu_ubl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,7 @@ void ubl_map_move_to_xy() {

// Use the built-in manual move handler to move to the mesh point.
ui.manual_move.set_destination(xy);
ui.manual_move.soon(ALL_AXES_MASK);
ui.manual_move.soon(ALL_AXES_ENUM);
}

inline int32_t grid_index(const uint8_t x, const uint8_t y) {
Expand Down
4 changes: 2 additions & 2 deletions Marlin/src/module/motion.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ void report_current_position_projected() {
void quickstop_stepper() {
planner.quick_stop();
planner.synchronize();
set_current_from_steppers_for_axis(ALL_AXES_MASK);
set_current_from_steppers_for_axis(ALL_AXES_ENUM);
sync_plan_position();
}

Expand Down Expand Up @@ -360,7 +360,7 @@ void set_current_from_steppers_for_axis(const AxisEnum axis) {
planner.unapply_modifiers(pos, true);
#endif

if (axis == ALL_AXES_MASK)
if (axis == ALL_AXES_ENUM)
current_position = pos;
else
current_position[axis] = pos[axis];
Expand Down

0 comments on commit cdbd438

Please sign in to comment.