Skip to content

Share x64 prefix lookup between interpreter and dynarec #3863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
necat101 wants to merge 26 commits into
base: main
Choose a base branch
from
+59 −20
Open

Share x64 prefix lookup between interpreter and dynarec #3863

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
40f1e7a
Update dynarec_arm64_00.c
necat101 May 10, 2026
bbeaf5b
Update dynarec_arm64_avx.c
necat101 May 10, 2026
766c85e
Update x64run_private.h
necat101 May 10, 2026
563912f
Update x64run.c
necat101 May 10, 2026
1156570
Update x64runavx.c
necat101 May 10, 2026
460b842
Merge branch 'ptitSeb:main' into main
necat101 May 12, 2026
23fa9ef
Update dynarec_arm64_avx.c
necat101 May 12, 2026
7a50b8a
Update dynarec_arm64_functions.c
necat101 May 12, 2026
6c1a895
Update dynarec_arm64_helper.c
necat101 May 12, 2026
f7a8fee
Update dynarec_native_functions.c
necat101 May 12, 2026
51c9034
Update x64runavx.c
necat101 May 12, 2026
4c18076
Merge branch 'ptitSeb:main' into main
necat101 May 13, 2026
52a7cf4
Update dynarec_arm64_arch.c
necat101 May 13, 2026
2da30a4
Update dynarec_arm64_functions.c
necat101 May 13, 2026
60a3fe4
Update dynarec_arm64_helper.c
necat101 May 13, 2026
91cc38f
Update dynarec_arm64_helper.h
necat101 May 13, 2026
492dfc0
Update dynarec_native_pass.c
necat101 May 13, 2026
07e2df1
Update dynarec_native_pass.c
necat101 May 13, 2026
d123c3e
Update x64run_private.c
necat101 May 13, 2026
320f3b6
Update x64run_private.h
necat101 May 13, 2026
ac44ac6
Update x64run.c
necat101 May 13, 2026
004ec39
Update dynarec_native_pass.c
necat101 May 13, 2026
4336763
Update x64run_private.c
necat101 May 13, 2026
2a7722e
Update x64run_private.h
necat101 May 13, 2026
a967ee5
Update x64run.c
necat101 May 13, 2026
f1cb3ea
Merge branch 'main' into main
necat101 May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/dynarec/dynarec_native_pass.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ uintptr_t native_pass(dynarec_native_t* dyn, uintptr_t addr, int alternate, int
rex.is67 = 0;
rex.isf0 = 0;
rex.rep = 0;
uint8_t prefix = x64_prefix_kind[pk];
uint8_t prefix = x64_prefix_kind_table[pk];
while(prefix && (prefix!=X64_PREFIX_REX || !is32bits)) {
switch (prefix) {
case X64_PREFIX_LOCK: rex.isf0 = 1; rex.rex = 0; break;
Expand All @@ -290,7 +290,7 @@ uintptr_t native_pass(dynarec_native_t* dyn, uintptr_t addr, int alternate, int
}
++addr;
pk = PK(0);
prefix = x64_prefix_kind[pk];
prefix = x64_prefix_kind_table[pk];
}
if(rex.isf0) {
if(rex.is66 && !rex.w)
Expand Down
31 changes: 13 additions & 18 deletions src/emu/x64run.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,26 +108,21 @@ int Run(x64emu_t *emu, int step)
rex.is67 = 0;
rex.isf0 = 0;
rex.rep = 0;
while((opcode==0xF2) || (opcode==0xF3) || (opcode==0xF0)
|| (opcode==0x3E) || (opcode==0x26) || (opcode==0x2e) || (opcode==0x36)
|| (opcode==0x64) || (opcode==0x65) || (opcode==0x66) || (opcode==0x67)
|| (!is32bits && (opcode>=0x40 && opcode<=0x4f))) {
switch (opcode) {
case 0xF0: rex.isf0 = 1; rex.rex = 0; break;
case 0xF2: rex.rep = 1; rex.rex = 0; break;
case 0xF3: rex.rep = 2; rex.rex = 0; break;
case 0x26: /* ES: */
case 0x2E: /* CS: */
case 0x36: /* SS; */
case 0x3E: /* DS; */
rex.seg = 0; rex.rex = 0; break;
case 0x64: rex.seg = _FS; rex.rex = 0; break;
case 0x65: rex.seg = _GS; rex.rex = 0; break;
case 0x66: rex.is66 = 1; rex.rex = 0; break;
case 0x67: rex.is67 = 1; rex.rex = 0; break;
case 0x40 ... 0x4F: rex.rex = opcode; break;
uint8_t prefix = x64_prefix_kind_table[opcode];
while(prefix && (prefix!=X64_PREFIX_REX || !is32bits)) {
switch (prefix) {
case X64_PREFIX_LOCK: rex.isf0 = 1; rex.rex = 0; break;
case X64_PREFIX_REP_F2: rex.rep = 1; rex.rex = 0; break;
case X64_PREFIX_REP_F3: rex.rep = 2; rex.rex = 0; break;
case X64_PREFIX_SEG0: rex.seg = 0; rex.rex = 0; break;
case X64_PREFIX_FS: rex.seg = _FS; rex.rex = 0; break;
case X64_PREFIX_GS: rex.seg = _GS; rex.rex = 0; break;
case X64_PREFIX_66: rex.is66 = 1; rex.rex = 0; break;
case X64_PREFIX_67: rex.is67 = 1; rex.rex = 0; break;
case X64_PREFIX_REX: rex.rex = opcode; break;
}
opcode = F8;
prefix = x64_prefix_kind_table[opcode];
}

if(rex.seg)
Expand Down
30 changes: 30 additions & 0 deletions src/emu/x64run_private.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,36 @@
#define from_ptrv(A) ((void*)(uintptr_t)(A))
#endif

const uint8_t x64_prefix_kind_table[256] = {
[0x26] = X64_PREFIX_SEG0,
[0x2e] = X64_PREFIX_SEG0,
[0x36] = X64_PREFIX_SEG0,
[0x3e] = X64_PREFIX_SEG0,
[0x40] = X64_PREFIX_REX,
[0x41] = X64_PREFIX_REX,
[0x42] = X64_PREFIX_REX,
[0x43] = X64_PREFIX_REX,
[0x44] = X64_PREFIX_REX,
[0x45] = X64_PREFIX_REX,
[0x46] = X64_PREFIX_REX,
[0x47] = X64_PREFIX_REX,
[0x48] = X64_PREFIX_REX,
[0x49] = X64_PREFIX_REX,
[0x4a] = X64_PREFIX_REX,
[0x4b] = X64_PREFIX_REX,
[0x4c] = X64_PREFIX_REX,
[0x4d] = X64_PREFIX_REX,
[0x4e] = X64_PREFIX_REX,
[0x4f] = X64_PREFIX_REX,
[0x64] = X64_PREFIX_FS,
[0x65] = X64_PREFIX_GS,
[0x66] = X64_PREFIX_66,
[0x67] = X64_PREFIX_67,
[0xf0] = X64_PREFIX_LOCK,
[0xf2] = X64_PREFIX_REP_F2,
[0xf3] = X64_PREFIX_REP_F3,
};


#ifdef HAVE_TRACE
#define PK(a) (*(uint8_t*)(ip+a))
Expand Down
14 changes: 14 additions & 0 deletions src/emu/x64run_private.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,20 @@
#include "symbolfuncs.h"
#include "x64emu.h"

enum {
X64_PREFIX_LOCK = 1,
X64_PREFIX_REP_F2,
X64_PREFIX_REP_F3,
X64_PREFIX_SEG0,
X64_PREFIX_FS,
X64_PREFIX_GS,
X64_PREFIX_66,
X64_PREFIX_67,
X64_PREFIX_REX,
};

extern const uint8_t x64_prefix_kind_table[256];

typedef struct rex_s {
union {
uint8_t rex;
Expand Down
Loading