Skip to content

Commit

Permalink
Fix absolute depfile causing python package to reinstall each build (n…
Browse files Browse the repository at this point in the history
…v-morpheus#769)

Follow up to nv-morpheus#754 which still reinstalled the package each build. This sets `cmake_minimum_required(3.24)` to match MRC and get consistent policies for the relative/absolute depfile options.

Also fixes some previous merge issues.

Authors:
  - Michael Demoret (https://github.com/mdemoret-nv)

Approvers:
  - Christopher Harris (https://github.com/cwharris)

URL: nv-morpheus#769
  • Loading branch information
mdemoret-nv committed Mar 17, 2023
1 parent cb22581 commit 9adf368
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
# limitations under the License.


cmake_minimum_required(VERSION 3.14 FATAL_ERROR)
cmake_minimum_required(VERSION 3.24 FATAL_ERROR)


list(APPEND CMAKE_MESSAGE_CONTEXT "morpheus")
Expand Down
2 changes: 1 addition & 1 deletion morpheus/_lib/cmake/python_modules/messages.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# the License.
# =============================================================================

morpheus_utils_add_pybind11_module(
morpheus_add_pybind11_module(
messages
SOURCE_FILES
"${MORPHEUS_LIB_ROOT}/src/python_modules/messages.cpp"
Expand Down
2 changes: 1 addition & 1 deletion morpheus/_lib/cmake/python_modules/stages.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# the License.
# =============================================================================

morpheus_utils_add_pybind11_module(
morpheus_add_pybind11_module(
stages
SOURCE_FILES
"${MORPHEUS_LIB_ROOT}/src/python_modules/stages.cpp"
Expand Down

0 comments on commit 9adf368

Please sign in to comment.