Fix file path handling in download router#299
Open
KroZen-Dev wants to merge 1 commit intopterodactyl:developfrom
Open
Fix file path handling in download router#299KroZen-Dev wants to merge 1 commit intopterodactyl:developfrom
KroZen-Dev wants to merge 1 commit intopterodactyl:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves how file downloads are handled in the
getDownloadFilefunction, focusing on safer and more accurate processing of file paths and filenames. The main changes include decoding URL-encoded file paths, extracting the correct filename for the download header, and updating imports to support these changes.File path handling and download improvements:
url.QueryUnescapeto ensure correct file access and prevent issues with encoded characters.s.Filesystem().Fileto use the decodedfilePathinstead of the original token value, ensuring the correct file is accessed.filepath.Baseto extract the filename from the full file path for theContent-Dispositionheader, ensuring the downloaded file has the correct name regardless of the original path.Dependency updates:
net/urlandpath/filepathto support URL decoding and filename extraction.🔗 Linked Issues: #5256