Skip to content

Close the QApplication when closing the app widget #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 31, 2020
Merged

Close the QApplication when closing the app widget #47

merged 2 commits into from
Oct 31, 2020

Conversation

Chilipp
Copy link
Member

@Chilipp Chilipp commented Oct 31, 2020 •
edited
Loading

This PR adds a new subclass of the DatasetWidget that lets the QApplication quit when the window is closed.

This subclass is now used for starting the app via command line

  • Tests passed (for all non-documentation changes)
  • Fully documented, including CHANGELOG.rst for all changes

@Chilipp
close all windows for standalone app
d7d3a57 
This commit adds a new subclass of the DatasetWidget
that lets the QApplication quit when
the window is closed.
This subclass is now used for starting the
app via command line
@Chilipp
add behavioural change in closing window to changelog
b8345d9
@Chilipp Chilipp self-assigned this Oct 31, 2020
@Chilipp Chilipp merged commit d265841 into psyplot:master Oct 31, 2020
@Chilipp Chilipp deleted the onclose branch October 31, 2020 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Chilipp Chilipp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Chilipp