Skip to content

Conversation

Chilipp
Copy link
Member

@Chilipp Chilipp commented Oct 21, 2021

related issue psyplot/psyplot#38

  • Tests passed (for all non-documentation changes)
  • Fully documented, including CHANGELOG.rst for all changes

@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #30 (4304a97) into develop (ac305c0) will increase coverage by 0.08%.
The diff coverage is 88.88%.

❗ Current head 4304a97 differs from pull request most recent head 5e96f63. Consider uploading reports for the commit 5e96f63 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #30      +/-   ##
===========================================
+ Coverage    66.02%   66.10%   +0.08%     
===========================================
  Files            9        9              
  Lines         4812     4803       -9     
===========================================
- Hits          3177     3175       -2     
+ Misses        1635     1628       -7     
Impacted Files Coverage Δ
psy_simple/plotters.py 82.87% <88.88%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac305c0...5e96f63. Read the comment docs.

@Chilipp Chilipp changed the base branch from master to develop October 23, 2021 05:03
@Chilipp Chilipp merged commit f8d664a into develop Nov 22, 2021
@Chilipp Chilipp deleted the fix/38 branch November 22, 2021 13:20
Chilipp added a commit that referenced this pull request Feb 14, 2022
Compatibility fixes

Changed
=======

- We now use the new `convert_coordinate` method that has been introduced with
  psyplot v1.4.1 (see psyplot/psyplot#39 and #30)

Fixed
=====
- psy-simple is now compatible with matplotlib 3.5 (see #31)
Chilipp added a commit to psyplot/psy-maps that referenced this pull request Feb 14, 2022
Fix projection issues

Fixed
-----

- `false_easting` and `false_northing` are now expected to be optional
  arguments for most projections (see #41)

Changed
-------
- we now use the `convert_coordinate` method that has been introduced
  in psyplot/psyplot#39 and psyplot/psy-simple#30. See #41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant