feat: auto-provision volumes on all machines for global services#243
Merged
psviderski merged 5 commits intopsviderski:mainfrom Feb 2, 2026
Merged
feat: auto-provision volumes on all machines for global services#243psviderski merged 5 commits intopsviderski:mainfrom
psviderski merged 5 commits intopsviderski:mainfrom
Conversation
zasdaym
force-pushed
the
global-volume
branch
2 times, most recently
from
f644e65 to
f0f610b
Compare
zasdaym
force-pushed
the
global-volume
branch
from
f0f610b to
7e34169
Compare
psviderski
reviewed
Jan 26, 2026
Owner
psviderski
left a comment
psviderski
left a comment
There was a problem hiding this comment.
Nice work! 👏
Overall looks great but please see one comment about the behaviour where we don't create new volumes for a global service if some already exist. Let's discuss this one and decide how it should work.
Contributor
Author
|
A diagram or table for this global/replicated/constraint/volume relationship in docs would be great. |
psviderski
reviewed
Jan 30, 2026
psviderski
reviewed
Jan 30, 2026
Owner
|
The change looks great now, thank you for the updates! Please reply to/address the last minor comments and we can merge this. |
Move isVolumeSharedBetweenGlobalAndReplicated check earlier to fail fast, then use isVolumeForGlobalService instead of the now-redundant isVolumeOnlyForGlobalServices function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create volumes on all eligible machines for global service. Fixes #234