Resolved all warnings

.github/workflows/test.yaml

@@ -30,7 +30,7 @@ jobs:
     - uses: actions-rs/clippy-check@v1
       with:
         token: ${{ secrets.GITHUB_TOKEN }}
-        args: -p psqlpy --all-features -- -W clippy::all -W clippy::pedantic
+        args: -p psqlpy --all-features -- -W clippy::all -W clippy::pedantic -D warnings
   pytest:
     name: ${{matrix.job.os}}-${{matrix.py_version}}-${{ matrix.postgres_version }}
     strategy:

.pre-commit-config.yaml

@@ -58,8 +58,8 @@ repos:
           - clippy::all
           - -W
           - clippy::pedantic
-          # - -D
-          # - warnings
+          - -D
+          - warnings
 
       - id: check
         types:

src/connection/impls.rs

@@ -110,6 +110,7 @@ impl Connection for SingleConnection {
 }
 
 impl StartTransaction for SingleConnection {
+    #[allow(clippy::used_underscore_items)]
     async fn start_transaction(
         &mut self,
         isolation_level: Option<IsolationLevel>,
@@ -125,13 +126,15 @@ impl StartTransaction for SingleConnection {
 }
 
 impl CloseTransaction for SingleConnection {
+    #[allow(clippy::used_underscore_items)]
     async fn commit(&mut self) -> PSQLPyResult<()> {
         self._commit().await?;
         self.in_transaction = false;
 
         Ok(())
     }
 
+    #[allow(clippy::used_underscore_items)]
     async fn rollback(&mut self) -> PSQLPyResult<()> {
         self._rollback().await?;
         self.in_transaction = false;
@@ -193,6 +196,7 @@ impl Connection for PoolConnection {
 }
 
 impl StartTransaction for PoolConnection {
+    #[allow(clippy::used_underscore_items)]
     async fn start_transaction(
         &mut self,
         isolation_level: Option<IsolationLevel>,
@@ -206,13 +210,15 @@ impl StartTransaction for PoolConnection {
 }
 
 impl CloseTransaction for PoolConnection {
+    #[allow(clippy::used_underscore_items)]
     async fn commit(&mut self) -> PSQLPyResult<()> {
         self._commit().await?;
         self.in_transaction = false;
 
         Ok(())
     }
 
+    #[allow(clippy::used_underscore_items)]
     async fn rollback(&mut self) -> PSQLPyResult<()> {
         self._rollback().await?;
         self.in_transaction = false;
@@ -324,13 +330,18 @@ impl CloseTransaction for PSQLPyConnection {
 }
 
 impl PSQLPyConnection {
+    #[must_use]
     pub fn in_transaction(&self) -> bool {
         match self {
             PSQLPyConnection::PoolConn(conn) => conn.in_transaction,
             PSQLPyConnection::SingleConnection(conn) => conn.in_transaction,
         }
     }
 
+    /// Prepare internal `PSQLPy` statement
+    ///
+    /// # Errors
+    /// May return error if there is some problem with DB communication.
     pub async fn prepare_statement(
         &self,
         querystring: String,
@@ -341,6 +352,10 @@ impl PSQLPyConnection {
             .await
     }
 
+    /// Execute prepared `PSQLPy` statement.
+    ///
+    /// # Errors
+    /// May return error if there is some problem with DB communication.
     pub async fn execute_statement(
         &self,
         statement: &PsqlpyStatement,
@@ -352,6 +367,10 @@ impl PSQLPyConnection {
         Ok(PSQLDriverPyQueryResult::new(result))
     }
 
+    /// Execute raw query with parameters.
+    ///
+    /// # Errors
+    /// May return error if there is some problem with DB communication.
     pub async fn execute(
         &self,
         querystring: String,
@@ -363,15 +382,12 @@ impl PSQLPyConnection {
             .await?;
 
         let prepared = prepared.unwrap_or(true);
-        let result = match prepared {
-            true => {
-                self.query(statement.statement_query()?, &statement.params())
-                    .await
-            }
-            false => {
-                self.query_typed(statement.raw_query(), &statement.params_typed())
-                    .await
-            }
+        let result = if prepared {
+            self.query(statement.statement_query()?, &statement.params())
+                .await
+        } else {
+            self.query_typed(statement.raw_query(), &statement.params_typed())
+                .await
         };
 
         let return_result = result.map_err(|err| {
@@ -383,6 +399,10 @@ impl PSQLPyConnection {
         Ok(PSQLDriverPyQueryResult::new(return_result))
     }
 
+    /// Execute many queries without return.
+    ///
+    /// # Errors
+    /// May return error if there is some problem with DB communication.
     pub async fn execute_many(
         &self,
         querystring: String,
@@ -431,6 +451,11 @@ impl PSQLPyConnection {
         Ok(())
     }
 
+    /// Execute raw query with parameters. Return one raw row
+    ///
+    /// # Errors
+    /// May return error if there is some problem with DB communication.
+    /// Or if cannot build statement.
     pub async fn fetch_row_raw(
         &self,
         querystring: String,
@@ -466,6 +491,11 @@ impl PSQLPyConnection {
         Ok(result)
     }
 
+    /// Execute raw query with parameters. Return one row
+    ///
+    /// # Errors
+    /// May return error if there is some problem with DB communication.
+    /// Or if cannot build statement.
     pub async fn fetch_row(
         &self,
         querystring: String,
@@ -479,6 +509,11 @@ impl PSQLPyConnection {
         Ok(PSQLDriverSinglePyQueryResult::new(result))
     }
 
+    /// Execute raw query with parameters. Return single python object
+    ///
+    /// # Errors
+    /// May return error if there is some problem with DB communication.
+    /// Or if cannot build statement.
     pub async fn fetch_val(
         &self,
         querystring: String,
@@ -495,6 +530,11 @@ impl PSQLPyConnection {
         })
     }
 
+    /// Create new sink for COPY operation.
+    ///
+    /// # Errors
+    /// May return error if there is some problem with DB communication.
+    /// Or if cannot build statement.
     pub async fn copy_in<T, U>(&self, statement: &T) -> PSQLPyResult<CopyInSink<U>>
     where
         T: ?Sized + ToStatement,
@@ -510,6 +550,14 @@ impl PSQLPyConnection {
         }
     }
 
+    /// Create and open new transaction.
+    ///
+    /// Unsafe here isn't a problem cuz it is stored within
+    /// the struct with the connection created this transaction.
+    ///
+    /// # Errors
+    /// May return error if there is some problem with DB communication.
+    /// Or if cannot build statement.
     pub async fn transaction(&mut self) -> PSQLPyResult<PSQLPyTransaction> {
         match self {
             PSQLPyConnection::PoolConn(conn) => {
@@ -531,33 +579,33 @@ impl PSQLPyConnection {
         }
     }
 
+    /// Create new Portal (server-side byte cursor).
+    ///
+    /// # Errors
+    /// May return error if there is some problem with DB communication.
+    /// Or if cannot build statement.
     pub async fn portal(
         &mut self,
         querystring: Option<&String>,
         parameters: &Option<pyo3::Py<PyAny>>,
         statement: Option<&PsqlpyStatement>,
     ) -> PSQLPyResult<(PSQLPyTransaction, tp_Portal)> {
-        let statement = {
-            match statement {
-                Some(stmt) => stmt,
-                None => {
-                    let Some(querystring) = querystring else {
-                        return Err(RustPSQLDriverError::ConnectionExecuteError(
-                            "Can't create cursor without querystring".into(),
-                        ));
-                    };
-
-                    &StatementBuilder::new(querystring, parameters, self, Some(false))
-                        .build()
-                        .await?
-                }
-            }
+        let stmt = if let Some(stmt) = statement {
+            stmt
+        } else {
+            let Some(querystring) = querystring else {
+                return Err(RustPSQLDriverError::ConnectionExecuteError(
+                    "Can't create cursor without querystring".into(),
+                ));
+            };
+
+            &StatementBuilder::new(querystring, parameters, self, Some(false))
+                .build()
+                .await?
         };
 
         let transaction = self.transaction().await?;
-        let inner_portal = transaction
-            .portal(statement.raw_query(), &statement.params())
-            .await?;
+        let inner_portal = transaction.portal(stmt.raw_query(), &stmt.params()).await?;
 
         Ok((transaction, inner_portal))
     }

src/connection/structs.rs

@@ -12,6 +12,7 @@ pub struct PoolConnection {
 }
 
 impl PoolConnection {
+    #[must_use]
     pub fn new(connection: Object, pg_config: Arc<Config>) -> Self {
         Self {
             connection,
@@ -31,6 +32,7 @@ pub struct SingleConnection {
 }
 
 impl SingleConnection {
+    #[must_use]
     pub fn new(connection: Client, pg_config: Arc<Config>) -> Self {
         Self {
             connection,

src/connection/traits.rs

@@ -57,7 +57,7 @@ pub trait Transaction {
         if let Some(level) = isolation_level {
             let level = &level.to_str_level();
             querystring.push_str(format!(" ISOLATION LEVEL {level}").as_str());
-        };
+        }
 
         querystring.push_str(match read_variant {
             Some(ReadVariant::ReadOnly) => " READ ONLY",

src/driver/common.rs

@@ -133,20 +133,21 @@ macro_rules! impl_cursor_method {
         #[pymethods]
         impl $name {
             #[pyo3(signature = (querystring=None, parameters=None, array_size=None))]
+            #[must_use]
             pub fn cursor(
                 &self,
                 querystring: Option<String>,
                 parameters: Option<Py<PyAny>>,
                 array_size: Option<i32>,
-            ) -> PSQLPyResult<Cursor> {
-                Ok(Cursor::new(
+            ) -> Cursor {
+                Cursor::new(
                     self.conn.clone(),
                     querystring,
                     parameters,
                     array_size,
                     self.pg_config.clone(),
                     None,
-                ))
+                )
             }
         }
     };
@@ -159,6 +160,10 @@ macro_rules! impl_prepare_method {
     ($name:ident) => {
         #[pymethods]
         impl $name {
+            /// Create new prepared statement.
+            ///
+            /// # Errors
+            /// May return error if there is some problem with DB communication.
             #[pyo3(signature = (querystring, parameters=None))]
             pub async fn prepare(
                 &self,
@@ -191,6 +196,10 @@ macro_rules! impl_transaction_methods {
     ($name:ident, $val:expr $(,)?) => {
         #[pymethods]
         impl $name {
+            /// Commit existing transaction.
+            ///
+            /// # Errors
+            /// May return error if there is some problem with DB communication.
             pub async fn commit(&mut self) -> PSQLPyResult<()> {
                 let conn = self.conn.clone();
                 let Some(conn) = conn else {
@@ -206,6 +215,10 @@ macro_rules! impl_transaction_methods {
                 Ok(())
             }
 
+            /// Rollback existing transaction.
+            ///
+            /// # Errors
+            /// May return error if there is some problem with DB communication.
             pub async fn rollback(&mut self) -> PSQLPyResult<()> {
                 let conn = self.conn.clone();
                 let Some(conn) = conn else {
@@ -230,6 +243,10 @@ macro_rules! impl_binary_copy_method {
     ($name:ident) => {
         #[pymethods]
         impl $name {
+            /// Perform binary copy to table.
+            ///
+            /// # Errors
+            /// May return error if there is some problem with DB communication.
             #[pyo3(signature = (source, table_name, columns=None, schema_name=None))]
             pub async fn binary_copy_to_table(
                 self_: pyo3::Py<Self>,

src/driver/connection.rs

@@ -158,7 +158,7 @@ impl Connection {
         read_conn_g.in_transaction()
     }
 
-    async fn __aenter__<'a>(self_: Py<Self>) -> PSQLPyResult<Py<Self>> {
+    async fn __aenter__(self_: Py<Self>) -> PSQLPyResult<Py<Self>> {
         let (db_client, db_pool, pg_config) = pyo3::Python::with_gil(|gil| {
             let self_ = self_.borrow(gil);
             (
@@ -191,7 +191,7 @@ impl Connection {
     }
 
     #[allow(clippy::unused_async)]
-    async fn __aexit__<'a>(
+    async fn __aexit__(
         self_: Py<Self>,
         _exception_type: Py<PyAny>,
         exception: Py<PyAny>,
@@ -278,7 +278,7 @@ impl Connection {
     /// 1) Cannot convert python parameters
     /// 2) Cannot execute querystring.
     #[pyo3(signature = (querystring, parameters=None, prepared=None))]
-    pub async fn execute_many<'a>(
+    pub async fn execute_many(
         self_: pyo3::Py<Self>,
         querystring: String,
         parameters: Option<Vec<Py<PyAny>>>,
@@ -369,7 +369,7 @@ impl Connection {
     /// 2) Cannot execute querystring.
     /// 3) Query returns more than one row
     #[pyo3(signature = (querystring, parameters=None, prepared=None))]
-    pub async fn fetch_val<'a>(
+    pub async fn fetch_val(
         self_: pyo3::Py<Self>,
         querystring: String,
         parameters: Option<pyo3::Py<PyAny>>,