allow newer opentelemetry-instrumentation packages #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the version formatting of opentelemetry-instrumentation constrains it to an old version
for more information, see https://pre-commit.ci
Member
|
@oliverlambson |
Contributor
Author
|
@chandr-andr the errors are the same ones currently failing on master, not related to the PR:
|
Contributor
Author
|
@chandr-andr I've fixed the pre-commit config and addressed the errors it was flagging let me know if you'd prefer me to move that to a separate PR |
Member
|
Thanks! I'll merge and make new release today as soon as I come home |
Contributor
Author
|
Thanks! Will you do a pypi release? Appreciate it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the version formatting of opentelemetry-instrumentation
^0.51b0constrains it to>=0.51b0,<0.52when i think the intention is actually for it to be>=0.51b0,<1i also added classifiers for the newer python versions since they were missing