-
Notifications
You must be signed in to change notification settings - Fork 4
TASK: only show button when enabled #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- use new `@neos-project/neos-ui-extensibility` stack with esbuild - remove dependency on `plow-js` - use provided `ckeditor-exports` rather than installing the `@ckeditor` this resolves a runtime error of having different ckeditor versions - add lock-file
|
Ill test this in 7.3 and 8.3 :) |
Co-authored-by: Marc Henry Schultz <85400359+mhsdesign@users.noreply.github.com>
mhsdesign
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update ;) It looks all good and works as expected. I could also confirm that the option splitAdd was not used previously.
properties:
text:
ui:
inline:
editorOptions:
formatting:
splitAdd: trueSo in the release notes - its still beta so all fine - it should be noted that this option is now always required to be used.
mhsdesign
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating the tech ;)
I can confirm that this works with Neos 8.3
Well at least how good the plugin ever worked ... i found a few bugs #9
but they are unrelated to this change.
|
as stated here #8 (review) please mark this change as breaking and add as upgrade note that you have to enable it ;) properties:
text:
ui:
inline:
editorOptions:
formatting:
splitAdd: true(cant edit messages on foreign repos ... dang ^^) |
|
@mhsdesign So you suggest that this is merged and released as a new major version, correct? I would then merge and release. |
|
@PRGfx Thanks for your contribution! |
This PR creates a new build of the plugin in order to only show the button when the feature is enabled in the node-type configuration.
Changes in this PR
As discussed in #6, this PR updates the build-stack to the current UI-extensibility setup:
@neos-project/neos-ui-extensibilitystack with esbuildplow-jsckeditor-exportsrather than installing the@ckeditorthis resolves a runtime error of having different ckeditor versions
How to verify
Open questions
ckeditor-exportsimport might have been breaking at some point...resolves #6