perf: use set instead of list for O(1) lookups in cookie operations #7124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace list with set for membership testing in cookie jar operations to improve performance from O(n) to O(1) per lookup: - list_domains(): Use set comprehension - list_paths(): Use set comprehension - multiple_domains(): Use set for tracking seen domains - cookiejar_from_dict(): Use set for existing cookie names lookup Benchmarks show 2-3x improvement for cookiejar_from_dict() which is called on every request preparation.
Contributor
|
This breaks implicit behaviour that some people are likely relying on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace list with set for membership testing in cookie jar operations to improve performance from O(n) to O(1) per lookup.
Changes
list_domains(): Use set comprehension instead of list withinchecklist_paths(): Use set comprehension instead of list withincheckmultiple_domains(): Use set for tracking seen domainscookiejar_from_dict(): Use set for existing cookie names lookupBenchmark Results
cookiejar_from_dict(overwrite=False)- called on every request:list_domains()utility method:Test Plan
list_domains(),list_paths(),multiple_domains(),cookiejar_from_dict()