ci: add minimum GitHub token permissions for workflows#6236
Merged
nateprewitt merged 1 commit intopsf:mainfrom Jan 11, 2023
Merged
ci: add minimum GitHub token permissions for workflows#6236nateprewitt merged 1 commit intopsf:mainfrom
nateprewitt merged 1 commit intopsf:mainfrom
Conversation
Signed-off-by: Ashish Kurmi <akurmi@stepsecurity.io>
Contributor
Author
|
@nateprewitt / @theGOTOguy / @sigmavirus24 : could you please review this PR? |
nateprewitt
approved these changes
Jan 11, 2023
Member
nateprewitt
left a comment
There was a problem hiding this comment.
I believe we already have the whole repository set to read only but this seems reasonable. Thanks @boahc077.
matthewarmand
pushed a commit
to matthewarmand/requests
that referenced
this pull request
May 10, 2023
Signed-off-by: Ashish Kurmi <akurmi@stepsecurity.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds minimum token permissions for the GITHUB_TOKEN in GitHub Actions workflows using https://github.com/step-security/secure-workflows.
The GitHub Actions workflow has a GITHUB_TOKEN with write access to multiple scopes.
Here is an example of the permissions in one of the workflow runs:
https://github.com/psf/requests/runs/8179910695?check_suite_focus=true#step:1:19
After this change, the scopes will be reduced to the minimum needed for the following workflows:
The following workflow already has the least privileged token permission set:
Motivation and Context
https://docs.github.com/en/actions/security-guides/automatic-token-authentication#modifying-the-permissions-for-the-github_token
Signed-off-by: Ashish Kurmi akurmi@stepsecurity.io