Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: fstring formatted with bytes #269

Merged
merged 2 commits into from
Feb 22, 2019
Merged

Fix: fstring formatted with bytes #269

merged 2 commits into from
Feb 22, 2019

Conversation

tvytlx
Copy link
Contributor

@tvytlx tvytlx commented Feb 21, 2019

this causes double-escaped, related issue #268

In [3]: hello=b"<span>hello\n  world \n</span>"

In [4]: f'<html>{hello}</html>'
Out[4]: "<html>b'<span>hello\\n  world \\n</span>'</html>"

@oldani
Copy link
Member

oldani commented Feb 21, 2019

Please add a test so we ensure this won't happen in the future.

@tvytlx tvytlx requested a review from oldani February 22, 2019 06:19
oldani
oldani approved these changes Feb 22, 2019
View reviewed changes
Copy link
Member

@oldani oldani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oldani oldani added this to the v0.11.0 milestone Feb 22, 2019
@oldani oldani merged commit afa7eb5 into psf:master Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oldani oldani oldani approved these changes

@timofurrer timofurrer Awaiting requested review from timofurrer

@kennethreitz kennethreitz Awaiting requested review from kennethreitz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tvytlx @oldani