-
Notifications
You must be signed in to change notification settings - Fork 89
ruff check and ruff format github action
#224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ruff check and ruff formatruff check and ruff format github action
|
I'm not convinced that @corona10: Do you have an opinion on this change? |
|
@vstinner Thank you for taking a look. It's customizable. We can figure out a set of Some background here: I was thinking about plugging in profiling.sampling over the holidays (the idea was to run all the I can remove the |
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/checkout@v6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should write a separated PR for these changes and the .github/dependabot.yml change.
This is very similar to what was done in pyperformance:
ruffis used since fdfd482, but was never enforced.I can split
ruff checkandruff formatinto two separate PRs for readability, similarly to python/pyperformance#405 and python/pyperformance#410 butruff checkis clean here:The PR also adds pre-commit, Dependabot and updates Github Action
checkout.