Skip to content

Conversation

@woodruffw
Copy link
Member

Closes #309.

@woodruffw woodruffw requested a review from frostming June 1, 2023 04:21
@woodruffw woodruffw self-assigned this Jun 1, 2023
@frostming
Copy link
Contributor

I think it may be a good idea to refactor a bit to extract the serialization/deserialization logic to its own class, instead of mixing them together. We can do it in the following PRs.

@woodruffw
Copy link
Member Author

woodruffw commented Jun 1, 2023

I think it may be a good idea to refactor a bit to extract the serialization/deserialization logic to its own class, instead of mixing them together. We can do it in the following PRs.

Yeah, sounds good. I need to do a little more cleanup in this PR but it should be ready in a moment.

Edit: done.

@woodruffw woodruffw merged commit 6aba616 into master Jun 1, 2023
@woodruffw woodruffw deleted the rm-old-cache-formats branch June 1, 2023 04:32
woodruffw added a commit to woodruffw-forks/cachecontrol that referenced this pull request Jul 9, 2024
* serialize: remove v1 and v2 formats

Closes psf#309.

* release_notes: document

* serialize: remove old imports and helpers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RFC: Remove serialize._loads_v1 and _loads_v2

3 participants