Skip to content

Conversation

@dimbleby
Copy link
Contributor

Fixes #281, #282

  • first commit explicitly excludes tests from the binary distribution, it is indeed unconventional to include them
  • second commit explicitly re-adds them to the source distribution
    • I don't think there's universal consensus about whether this is desirable or not eg here is a recent discussion
    • but it seems harmless and seeing as how No tests in pypi sdist tarball #281 explicitly asks for them, well why not?

@itamarst
Copy link
Contributor

This would enable re-releasing the yanked .12 release, seems like a good idea.

@itamarst
Copy link
Contributor

itamarst commented Apr 6, 2023

Any chance this can be merged and a new release made? Thanks!

@KOLANICH
Copy link

Thanks for fixing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No tests in pypi sdist tarball

4 participants