Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report all stacktraces in verbose mode #3938

Merged
merged 6 commits into from
Oct 10, 2023
Merged

Conversation

hauntsaninja
Copy link
Collaborator

@hauntsaninja hauntsaninja commented Oct 9, 2023

Previously these were swallowed; make the reporting more as like black/__init__.py

Previously these were swallowed (unlike the ones in black/__init__.py)
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

diff-shades reports zero changes comparing this PR (b5778a3) to main (5d5bf6e).


What is this? | Workflow run | diff-shades documentation

Comment on lines 174 to 176
elif task.exception():
report.failed(src, str(task.exception()))
exc = task.exception()
assert exc is not None
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a walrus so you can avoid the assert?

elif exc := task.exception():

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right, we dropped 3.7

@hauntsaninja hauntsaninja merged commit 7aa37ea into psf:main Oct 10, 2023
37 of 41 checks passed
@hauntsaninja hauntsaninja deleted the stacktrace branch October 10, 2023 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants