[WIP] Fix fmt on and off for comments #2114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It needs A LOT of cleanup and also needs two correctness fixes, but other than that, tests (except for fmtonoff5 since one of the examples needs one of the correctness fixes) pass.
ichard26
force-pushed
the
fix-fmt-on-and-off-for-comments
branch
from
0f54d28
to
8baf14e
Compare
|
I've been hacking on this for several hours now and I still can't get it right even with letting a few edge cases stay broken, I don't see myself fixing this anytime soon and I don't think I want to try again. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GH-1245.
Tests are complete and the fixing patch is mostly done, although it needs A LOT of cleanup and also needs two correctness fixes.
All tests (except for fmtonoff5 since one of the examples needs one of the correctness fixes) should pass.